Fix comparison between integer expressions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison yielded compile-time error on GCC 6.1.1.
| @@ -30,7 +30,7 @@ TEST(CommandlineOptions, allOptionsPresent) { | |||
| using Cynara::CmdlineOpts::commandlineOptions; | |||
|
|
|||
| // A cheap trick to make sure this test is updated, when new options are added | |||
| ASSERT_EQ(18, commandlineOptions.size()); | |||
| ASSERT_EQ(18u, commandlineOptions.size()); | |||
There was a problem hiding this comment.
-
As far as I know, you are still employee of Samsung.
Making such a change - please update Samsung's copyrights. -
Please make your changes compatible with the way, there were fixed previously, e.g. in commit ed1c9d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison yielded compile-time error on GCC 6.1.1.