Refactor to use async methods for network calls #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes all of the public methods in
ILRS
returnTask
objects, and implements these asasync
methods inRemoteLRS
. Some related changes:MyHTTPRequest
andMyHTTPResponse
have been moved toLRSHttpRequest
andLRSHttpResponse
HttpClient
is used instead ofHttpWebRequest
for betterasync
support, and so that this library can be used as a PCL, asHttpWebRequest
is not part of the .NET Portable Subset.async
only requires 4.0, butHttpClient
requires 4.5).async
tests.TCAPIVersion
to allow unit tests to pass.This is the first in a series of pull requests, as we made a number of changes to this library at @gowithfloat for a recent project, and would like to integrate them back into the core library. Some of these changes will be breaking (like this one).
I know there's another pull request that adds
async
version of methods, but as these are all network calls, they should be refactored to only beasync
. There's also a related issue currently open.Please let me know if you have any questions or comments. Thanks!