Consolidating open PRs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActivityDefinition has been extended to include: interactionType correctResponsesPattern choices scale target step This as been based on the work carried out by Paul Carpenter and is my first GitHub submission.
brianjmiller
approved these changes
Sep 4, 2018
| public List<InteractionComponent> scale { get; set; } | ||
| public List<InteractionComponent> source { get; set; } | ||
| public List<InteractionComponent> target { get; set; } | ||
| public List<InteractionComponent> steps { get; set; } |
There was a problem hiding this comment.
It will probably become a need pretty quickly to allow for individual additions of a single InteractionComponent to each of these lists. The public interface of the class requires you to set the whole list. That's been an issue elsewhere in the library in the past. Not something that has to hold up this PR, but it is something to be aware of for the future.
|
@reedmclean go with it, I'll let you do the honors and cut the release. If you need assistance with that, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to pull in the good contributions from open PRs that we haven't addressed in the last couple of years. A good chunk of them have changes that I think would benefit the library, but they've been left open for long enough that I think the interest in fixing them has significantly waned. They either have changes requested of them or conflicts with
master, so instead of individually checking out each branch, applying the fixes, and opening new PRs for each of them, I cherry-picked the relevant commits, applied necessary changes, and combined them into this PR. This will let us pull in contributions and close out the majority of open PRs.This PR (along with #23, which I merged this morning) also represents the features that I think should be included in the next minor version. There are a couple things that I would really like to pull into this library (#30 and #39 are frontrunners), but they would involve backward-incompatible changes that would require us to increment the major version before releasing. These changes possibly include incrementing the minimum Framework version up to 4.5, so I'd like to include as many features as possible before introducing breaking changes.
I'm hoping that the commits are distinct enough to make reviewing this relatively painless. On the other hand, this is a single PR covering multiple features, so I understand if it would be easier to review if it was split into separate PRs. Let me know if that's preferable, and I can do that.