Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend drake_ros_core package. #6

Merged
merged 15 commits into from
Dec 6, 2021
Merged

Extend drake_ros_core package. #6

merged 15 commits into from
Dec 6, 2021

Commits on Nov 9, 2021

  1. Revamp drake_ros_core package 

    - Sort out public/private API boundaries
- Use raw pointers instead of std::shared_ptr
- Improve compliance with Drake's C++ style
- Extend Doxygen docstrings

Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    efc7f7c View commit details
    Browse the repository at this point in the history

  2. Add Python bindings to drake_ros_core package. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    4a9404f View commit details
    Browse the repository at this point in the history

  3. Cope with Python 2 pollution in CI. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    e8a7859 View commit details
    Browse the repository at this point in the history

  4. Fix drake_ros_core C++ and Python pub/sub tests. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    4842d76 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Improve drake_ros_core::DrakeRos API 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    8185909 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Allow drake_ros_core::RosSubscriberSystem::Make argument type inference 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    92c921d View commit details
    Browse the repository at this point in the history

  2. Simplify drake_ros_core C++ and Python pub/sub tests. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    b56f073 View commit details
    Browse the repository at this point in the history

  3. Remove large timeout from Python pub/sub test. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8e23c11 View commit details
    Browse the repository at this point in the history

  4. Use spin_some() in DrakeRos::Spin() implementation. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8836bc4 View commit details
    Browse the repository at this point in the history

  5. Pass explicit node name to DrakeRos 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7db7f58 View commit details
    Browse the repository at this point in the history

  6. Update variable names in tests. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a395cdb View commit details
    Browse the repository at this point in the history

  7. Correct DrakeRos implementation comments 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    da5dcfb View commit details
    Browse the repository at this point in the history

  8. Please clang-format 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a423aa3 View commit details
    Browse the repository at this point in the history

  9. Add TODO to DrakeRos::Spin implementation. 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    74f4a80 View commit details
    Browse the repository at this point in the history

  10. Add explicit init/shutdown API to drake_ros_core 

    Signed-off-by: Michel Hidalgo <[email protected]>
    @hidmic
    hidmic committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    471c8c2 View commit details
    Browse the repository at this point in the history