linux-64 - rebuild Christmas 2024 - switch to rattler-build #229
+3,726
−1,030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was superseded by moveit/moveit2#2399 .
…in.patch The patch was integrated upstream in moveit/moveit2#2395 .
…eason is not added
Heavely based on RoboStack/ros-jazzy#5
|
I can't work on this more today, but I wonder if we need to back port https://github.com/moveit/moveit2/pull/2811/files . |
|
New failure: This is because of: Note we already have: https://github.com/traversaro/ros-humble/blob/rebuild-christmas-2024-linux-64-rattler-build/patch/ros-humble-webots-ros2-driver.patch I wonder if |
In theory that is set in the activation scripts of |
|
Great, I could not reproduce this locally. |
I also tried to print the |
|
New local failure: I know this, it is a missing |
|
Again, like for qt5, vtk and pcl this is another case of package having a non-obvious header dependencies without a *-devel package to capture them: https://github.com/conda-forge/libspnav-feedstock . |
Workaround in 832d69a . Long-term issue for avoid forgetting: RoboStack/robostack.github.io#65 . |
|
At least locally now all the @Tobias-Fischer do you think it would make sense if I look into integrating the snapshot system introduced in RoboStack/vinca#59 here? Now that we have a fully working build on linux (modulo the GitHub Actions webots failure, but I want to look into that) this may be a good time to take a snapshot and just iterate on that. |
Thanks a lot for all your work on this! And yes, let’s take a snapshot, hopefully this will help with package requests etc |
This was referenced Dec 22, 2024
Open
This was referenced Dec 22, 2024
|
There seems to be some error in the new fastrtps patch: |
|
Cool, ~650 packages are built in ~4 hours on GitHub Actions for linux-64. |
|
Great work thanks Silvio! Let me do a proper review over the next few days. What is the plan, do we want to tackle the other platforms in a separate pull request? We should keep track of which issues will be resolved with this PR. Oh, and how do you run the new tests? Would it make sense to run them on CI? |
|
How did the pinnings work now? I don’t think the conda_forge_pinnings.yaml is being used anymore? |
|
I guess for this to work we need to puill in https://github.com/RoboStack/ros-jazzy/tree/main/.scripts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an attempt, heavily based on:
Fix #217