wip: make additional recipes ready for rattler-build #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
commented
Apr 10, 2024
| @@ -17,35 +17,35 @@ python: | |||
| python_impl: | |||
| - cpython | |||
|
|
|||
| # Project overrides | |||
There was a problem hiding this comment.
This section can be re-written for the new format
wolfv
commented
Apr 10, 2024
|
|
||
|
|
||
| # fix build metadata, needed for mapviz and moveit-core | ||
| replacements: |
There was a problem hiding this comment.
This section has no equivalent yet in the new format. However, I am planning to add this functionality in the recipe.yaml rather than in the variant config because I don't understand why this was ever placed in that file in the first place.
|
Hey @wolfv - this is cool! Do we have a conda_forge_pinnings.yaml yet that works with rattler-build? |
|
See #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tobias-Fischer these are the changes that I had to do :) I actually only tested a subset of all packages so there may be 🐛 's