Nmark tactic #1664
Nmark tactic #1664
Conversation
| skills = self.two_mark.tick(role_results[self.two_mark]) | ||
| skill_dict = {} | ||
| # skill_dict.update(role_results[self.striker_tactic]) | ||
| skill_dict.update(role_results[self.two_mark]) |
There was a problem hiding this comment.
I'd appreciate it if you could remove the dead code.
| # Get role requests from all tactics and put them into a dictionary | ||
| role_requests: play.RoleRequests = {} | ||
| # role_requests[self.striker_tactic] = self.striker_tactic.get_requests(world_state, None) | ||
| role_requests[self.two_mark] = (self.two_mark.get_requests(world_state, None)) |
There was a problem hiding this comment.
Shouldn't this have a tactic for the robot kicking the ball? And also in theory a pass seeking tactic.
There was a problem hiding this comment.
Yes and yes. I started off writing the defensive clear play only to realize both the nmark and striker tactics weren't written yet. So this PR is step 1. For step 2 I'll write a striker tactic, uncomment the aforementioned "dead code", and possibly add the pass seeker, then put up a new PR for the full defensive clear play.
|
|
||
| def create_request(self, **kwargs) -> role.RoleRequest: | ||
| """Creates a sane default RoleRequest. | ||
| :return: A list of size 1 of a sane default RoleRequest. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
| def create_request(self, **kwargs) -> role.RoleRequest: | |
| """Creates a sane default RoleRequest. | |
| :return: A list of size 1 of a sane default RoleRequest. | |
| """ | |
| pass |
There was a problem hiding this comment.
should be fixed at the interface level, as discussed on Teams, ignoring for now
| from dataclasses import dataclass | ||
| from typing import List, Optional | ||
|
|
||
| import stp.action as action |
There was a problem hiding this comment.
I believe action is imported but not used
There was a problem hiding this comment.
It is not, nice catch
Description
This implements the nmark tactic, which marks the n enemies closest to the ball with the robots of ours that are closest to them. For now, ignore the roughness of the
defensive_clear.pyfile, it will be uncommented and filled in once pivot_kick from #1644 is merged in.Associated Issue
https://app.clickup.com/t/y3fvx9
Steps to test
Test Case 1
Expected result: Our 2 closest robots to the 2 enemies closest to the ball should move to mark those enemies, regardless of where the ball is. (I know this wording is a little unclear but the behavior makes sense when you see it.)
Test Case 2
init()ofplay/defensive_clear.pythat controls how many robots nmark handles.Expected result: NMark works the same, but with more (or less) than 2 robots.