Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move variable into main fn #19

Merged
merged 2 commits into from
Jan 7, 2025
Merged

fix: move variable into main fn #19

merged 2 commits into from
Jan 7, 2025

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Jan 6, 2025

Section 8.4 on panning had a listing show diff where a new variable was introduced outside main, which should've been within it. This fixes it.

armansito
armansito approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@armansito armansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you for the fix!

book/RayTracingGPUEdition.html Show resolved Hide resolved
@armansito armansito merged commit aeab5cd into RayTracing:dev Jan 7, 2025
@mTvare6
Copy link
Contributor Author

mTvare6 commented Jan 7, 2025

@armansito while not critical, there are not dots between main and variable and event loop, maybe there should be one somewhere?

@mTvare6 mTvare6 mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armansito armansito armansito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mTvare6 @armansito