Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move into main fn #20

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Jan 7, 2025

Fixes edit as mention here.

I also wanted to ask if this repo would accept non-trivial additions, maybe more than one material and handling them to be as compliant as possible with RTIOW Book 1.

@armansito
Copy link
Collaborator

Thank you for the fix!

I also wanted to ask if this repo would accept non-trivial additions, maybe more than one material and handling them to be as compliant as possible with RTIOW Book 1.

The book is still a work in progress and I'm currently working on getting the first draft into a good state (granted my progress has been slow over the last few months but I'm finally picking up the pace again).

The section on materials is actually the next on the list and I'm currently working on it. I'm planning to upload the first part of it soon, so stay tuned!

@armansito armansito merged commit e69e2d5 into RayTracing:dev Jan 7, 2025
@mTvare6
Copy link
Contributor Author

mTvare6 commented Jan 7, 2025

The section on materials is actually the next on the list and I'm currently working on it. I'm planning to upload the first part of it soon, so stay tuned!

That's great, I'm looking forward to that! In case what I meant wasn't clear, by additions I asked if this accepted non-trivial prs. And maybe using draft prs would make it easier for potential contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants