Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better last batch logic #12827

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Better last batch logic #12827

merged 7 commits into from
Sep 21, 2023

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Sep 19, 2023 •
edited
Loading

Proposed changes:

  • Solves issues were single examples made it into the last batch and created updates with bad directions
  • made sure there's always at least one batch per epoch
  • dropping the last batch if it has less than 50% of batch size

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister requested a review from a team as a code owner September 19, 2023 12:31
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12827--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@twerkmeister twerkmeister requested a review from tmbo September 21, 2023 07:57
tmbo
tmbo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@twerkmeister twerkmeister merged commit 65ed774 into 3.6.x Sep 21, 2023
95 checks passed
@twerkmeister twerkmeister deleted the ENG-448-better-last-batch branch September 21, 2023 08:33
twerkmeister added a commit that referenced this pull request Sep 21, 2023
@twerkmeister
Better last batch logic (#12827)
1fdc9a1 
* Better last batch logic
@twerkmeister twerkmeister mentioned this pull request Sep 21, 2023
Merged
4 tasks
twerkmeister added a commit that referenced this pull request Sep 21, 2023
@twerkmeister
Better last batch logic (#12827) (#12840)
f9a2b82 
* Better last batch logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twerkmeister @tmbo