Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better last batch logic (#12827) #12840

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Sep 21, 2023

  • Better last batch logic

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

* Better last batch logic
@twerkmeister twerkmeister requested a review from a team as a code owner September 21, 2023 11:58
@twerkmeister twerkmeister requested review from djcowley and removed request for a team September 21, 2023 11:58
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12840--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@twerkmeister twerkmeister merged commit f9a2b82 into 3.4.x Sep 21, 2023
111 of 112 checks passed
@twerkmeister twerkmeister deleted the ENG-448-better-last-batch-34x branch September 21, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants