WIP: GBA LOGO 🎆 🥳 🔥 🎉 #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessioC31
force-pushed
the
logo
branch
2 times, most recently
from
ec02596 to
ac0bf77
Compare
Signed-off-by: Federico Guerinoni <[email protected]>
Signed-off-by: Federico Guerinoni <[email protected]>
Signed-off-by: Federico Guerinoni <[email protected]>
Signed-off-by: Federico Guerinoni <[email protected]>
This is not used Signed-off-by: Federico Guerinoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #212 .
Well... we still have a lot to do but this PR starts implementing Sprite rendering.
For now we're assuming we only have sprites in BG mode 2 (the one used by the gba logo).
We miss effects, object window concept, and so on.
Screen.Recording.2023-09-24.at.13.41.21.mov
We were calculating
carrywrong for sub operations. This was resulting in some comparisons failing (and then we were taking some branches that we did not have to take and vice-versa).