Merge Feature/v3 into main #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* More consistency with typing for py3.10+ - Using ruff and stricter pyright settings. Will have to remove later. * Fix another union and eliminate an unnecessary cast. * Revert pyproject.toml configuration. - Leave two extra pyright settings on — they can't hurt, right? * Incorporate feedback and also change filter payload imports to relative. - Not as sure on the relative import change. In my opinion, this is a clearer indicator of where the imports are coming from, is more consistent with similar imports in other files, and doesn't run the risk of messing with an import of builtin types module, unlikely as that is to happen. Might be a matter of style though. * More minor explicit type-aliasing.
This was
linked to
issues
Nov 27, 2023
AbstractUmbra
approved these changes
Nov 27, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
feature/v3intomain.Version 3 will now become the stable release after merging.
Version 3 went through
16BETA stages and2Release Candidate stages.To the best of my knowledge all major bugs have been found, and this version should be considered fairly stable at this point.
Documentation is complete minus some minor QoL examples and recipes.
This version complies with pyright strict and no errors or warnings are currently being emitted.
Black has been ran over this version.
Checklist