Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/v3] TrackEndEventPayload.player is often missing #252

Closed
atomic-junky opened this issue Nov 18, 2023 · 5 comments · Fixed by #254
Closed

[feature/v3] TrackEndEventPayload.player is often missing #252

atomic-junky opened this issue Nov 18, 2023 · 5 comments · Fixed by #254

Comments

@atomic-junky
Copy link

atomic-junky commented Nov 18, 2023

Hi,
Almost every time a track_end event is issued, the player attribute is missing on the v3 branch.
I think it also happens a few times for the track_start event, but it's rarer.
(I'm using Lavalink v4.0.0-beta.5)

Btw thanks for maintaining wavelink

@EvieePy
Copy link
Member

EvieePy commented Nov 18, 2023

I doubt this is happening unless you are disconnecting the player or removing it from the node. I have tested AutoPlay extensively and it requires a player to be available at the time this event fires to work.

Almost everytime seems weird, Everytime could be a bad bug?

Are you able to provide your wavelink version, and sample code of your events and play command.

You can run py -m wavelink --version

@atomic-junky
Copy link
Author

I didn't manage to reproduce the bug, I may have set it unintentionally but I had the impression that it only happened with the normal queue.
It's very likely that the mistake came from me, but is it possible that it came from Lavalink?
Sorry for the inconvenience, I don't know what happened.

@EvieePy
Copy link
Member

EvieePy commented Nov 18, 2023

Not sure tbh. Are you able to run simple.py and add a track end to that and try printing the player? Also do you know your wavelink version?

@EvieePy EvieePy reopened this Nov 18, 2023
@EvieePy
Copy link
Member

EvieePy commented Nov 18, 2023

Sorry reopening, because I would like to know if there is a potential bug here or not.

@atomic-junky
Copy link
Author

I have wavelink 3.0.0rc1 and when I run simple.py all goes well and with my personal bot too

@EvieePy EvieePy linked a pull request Nov 27, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants