Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for all social care extracts #854

Merged
merged 16 commits into from
Nov 21, 2023
Merged

Conversation

Jennit07
Copy link
Collaborator

@Jennit07 Jennit07 commented Nov 6, 2023

addresses #842

Produces tests for social care all extracts. The data is the processed extract taken from the social care platform containing all years worth of data.

Still to do:

  • Add these tests into the targets pipeline. (@SwiftySalmon happy to have a call with you to share how to do this!)

This comment has been minimized.

@Jennit07 Jennit07 changed the title Create tests for all social care Create tests for all social care extracts Nov 6, 2023
@Jennit07
Copy link
Collaborator Author

JT - still to test HC and SDS. Also need to have a call to put this into the targets pipeline.

@Jennit07 Jennit07 mentioned this pull request Nov 20, 2023
11 tasks

This comment has been minimized.

This comment has been minimized.

@Jennit07 Jennit07 marked this pull request as ready for review November 21, 2023 11:22

This comment has been minimized.

@Jennit07
Copy link
Collaborator Author

@SwiftySalmon This one is ready to check/merge

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

hri

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the sc_at_tests branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/6946956202/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (232) from .github/actions/spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:swift/src/swift.txt 53 2
cspell:k8s/dict/k8s.txt 153 1 1
cspell:fullstack/dict/fullstack.txt 419 1 1
cspell:csharp/csharp.txt 32 1
cspell:filetypes/filetypes.txt 264 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:swift/src/swift.txt
          cspell:k8s/dict/k8s.txt
          cspell:fullstack/dict/fullstack.txt
          cspell:csharp/csharp.txt
          cspell:filetypes/filetypes.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (3)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 2
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@SwiftySalmon SwiftySalmon merged commit fc5652f into dec-update-23 Nov 21, 2023
11 of 12 checks passed
@SwiftySalmon SwiftySalmon deleted the sc_at_tests branch November 21, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants