Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for each 'all' sc extracts #842

Closed
4 tasks done
Jennit07 opened this issue Sep 29, 2023 · 1 comment
Closed
4 tasks done

Create tests for each 'all' sc extracts #842

Jennit07 opened this issue Sep 29, 2023 · 1 comment
Labels
Priority: Medium Testing Improvements or additions to testing

Comments

@Jennit07
Copy link
Collaborator

Jennit07 commented Sep 29, 2023 •
edited
Loading 

          Looking at this issue, i have discovered we already have `create_sending_location_test_flags` in the 'year' social care tests. However this is called `create_lca_test_flags` instead. The reason for this is because we create the `sending_lca` variable using `sending_location` at this stage in the 'processed' extracts. This function provides a count for each LCA area.

We need to keep create_sending_location_test_flags as the client lookup does not have the lca variable so i think it is useful to keep both functions.

I have also identified by looking at this issue that there are no tests for the 'all' sc files. I will make another issue to have a look at this again. However, on the branch i created i could apply create_sending_location_test_flags so i will push this and connect to this issue!

Originally posted by @Jennit07 in #818 (comment)

Tests for each sc 'all' extract:

  • All Alarms Telecare
  • All Care Home
  • All Home Care
  • All SDS
@Jennit07 Jennit07 added Testing Improvements or additions to testing Priority: Medium labels Sep 29, 2023
@Jennit07 Jennit07 mentioned this issue Nov 6, 2023
Merged
SwiftySalmon added a commit that referenced this issue Nov 21, 2023
@SwiftySalmon
Create tests for all social care extracts (#854)
fc5652f 
addresses #842 

Produces tests for social care `all` extracts. The data is the processed
extract taken from the social care platform containing all years worth
of data.

Still to do: 
- Add these tests into the targets pipeline. (@SwiftySalmon happy to
have a call with you to share how to do this!)
@Jennit07
Copy link
Collaborator Author

Jennit07 commented Jan 8, 2024

completed in #854

@Jennit07 Jennit07 closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Testing Improvements or additions to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jennit07