Expand suggest_dataset_name to potentially suggest multiple datasets names

R/suggest_dataset_name.R

@@ -17,16 +17,16 @@ suggest_dataset_name <- function(dataset_name) {
       "Can't find the dataset name
       {.var {dataset_name}}, or a close match.",
       i = "Find a dataset's name in the URL
-      of it's page on {.url www.opendata.nhs.scot.}"
+      of its page on {.url www.opendata.nhs.scot.}"
     ))
   }
 
   # find closet match
-  closest_match <- dataset_names[which.min(string_distances)]
+  closest_match <- dataset_names[which(string_distances == min(string_distances))]
 
   # throw error with suggestion
   cli::cli_abort(c(
     "Can't find the dataset name {.var {dataset_name}}.",
-    "i" = "Did you mean '{closest_match}'?"
+    "i" = "Did you mean {?any of }{.val {closest_match}}?"
   ))
 }

tests/testthat/test-get_dataset.R

@@ -18,6 +18,6 @@ test_that("errors properly", {
     regexp = "Can't find the dataset name `dataset-name-with-no-close-match`"
   )
   expect_error(get_dataset("gp-practice-population"),
-    regexp = "Did you mean 'gp-practice-populations'?"
+    regexp = "Did you mean .+?gp-practice-populations.+?\\?"
   )
 })

tests/testthat/test-suggest_dataset_names.R

@@ -12,6 +12,13 @@ test_that("throws error and does suggest for close matches", {
     phsopendata:::suggest_dataset_name(
       "rospital-codes"
     ),
-    regexp = "Did you mean 'hospital-codes'?"
+    regexp = "Did you mean .+?\\?"
+  )
+
+  expect_error(
+    suggest_dataset_name(
+      "population"
+    ),
+    regexp = "Did you mean any of .+?\\?"
   )
 })