Expand suggest_dataset_name to potentially suggest multiple datasets names
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that for the prompt `populations` it was suggesting `hospital-codes`, this was because there were multiple 'options' that were equally 'close'. This tweak allows suggesting any amount when many are equally close. I don't think `hospital-codes` is at all a good suggestion for `populations` but to fix that we'd have to change how it works out the string distances (e.g. change the `method`).
Moohan
force-pushed
the
feature/suggest_multiple_datasets
branch
from
067e5b0 to
15549c4
Compare
csillasch
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that for the prompt
populationsit was suggestinghospital-codes, this was because there were multiple 'options' that were equally 'close'. This tweak allows suggesting any amount when many are equally close.I don't think
hospital-codesis a good suggestion forpopulationsbut to fix that we'd have to change how it works out the string distances (e.g. change themethod).