Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview PRs via Netlify + GitHub Actions #167

Merged
merged 2 commits into from
Sep 26, 2021
Merged

Preview PRs via Netlify + GitHub Actions #167

merged 2 commits into from
Sep 26, 2021

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Sep 23, 2021 •
edited
Loading

Towards #157.

Note:

  1. Changes in this PR will take effect once this PR is merged
  2. Readthedocs previews should be disabled once we have confirmation that GitHub Actions + Netlify are working properly

@andersy005 andersy005 requested a review from a team as a code owner September 23, 2021 21:40
@andersy005 andersy005 requested review from dcamron and mgrover1 and removed request for a team September 23, 2021 21:40
@andersy005 andersy005 mentioned this pull request Sep 23, 2021
Merged
@andersy005 andersy005 requested a review from kmpaul September 23, 2021 21:47
mgrover1
mgrover1 previously approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @andersy005

kmpaul
kmpaul approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, @andersy005!

mgrover1
mgrover1 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

@andersy005 andersy005 merged commit 6a63901 into ProjectPythia:main Sep 26, 2021
@andersy005 andersy005 deleted the switch-to-netlify+gha branch September 26, 2021 21:22
@brian-rose brian-rose mentioned this pull request Oct 7, 2021
Closed
@kmpaul kmpaul mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@kmpaul kmpaul kmpaul approved these changes

@dcamron dcamron Awaiting requested review from dcamron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersy005 @kmpaul @mgrover1