Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe to remove readthedocs.yml and requirements.txt? #174

Closed
kmpaul opened this issue Oct 7, 2021 · 0 comments · Fixed by #175
Closed

Safe to remove readthedocs.yml and requirements.txt? #174

kmpaul opened this issue Oct 7, 2021 · 0 comments · Fixed by #175
Labels
infrastructure Infrastructure related issue

Comments

@kmpaul
Copy link
Collaborator

kmpaul commented Oct 7, 2021

With the merge of #167, it seems that we do not need to keep the readthedocs.yml file nor the ci/environment_pip.txt (i.e., requirements.txt) file. However, I don't want to delete these resources if they are needed for existing/old PRs, for example. Is it safe to remove these files?

(Regarding the old PRs, my question really comes down to whether the CI configuration files are read from the PR branch/fork or from the main branch. I think they are read from the PR branch, which means deleting these files shouldn't break anything.)

@kmpaul kmpaul added the infrastructure Infrastructure related issue label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant