Change bot.experience.points to bot.score, the packed has been mislabeled #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see the value of this breaking change |
sir this is clearly misleading, especially considering the fact that we have an actual xp points function in #3124 I think it should be looked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packet has been incorrectly labeled as "xp points" for a while on both mineflayer and wiki.vg. In reality, it only represents a player's score.
One's score is all the xp they have gathered in one life, and is displayed on death. I would consider it a simplistic stat and a general attribute of a player which is why I am moving it to the bot object.
(https://discord.com/channels/413438066984747026/413438150594265099/1134240353738825790)