-
-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to get the total xp points the bot has. #3124
Open
zisis912
wants to merge
3
commits into
PrismarineJS:master
Choose a base branch
from
zisis912:xp-getter-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/fixlint |
I fixed all linting errors with |
@zisis912 please fix the lint with above command |
actually fixed please add this function to the doc |
@zisis912 would you like to finish this? |
I am a bit busy yhese days, maybe in a few docs i will get around to making docs for all of my PRs so they can be finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike its title, the
bot.experience.points
property does NOT provide one with the xp points the bot has, but rather its score, displayed only when one dies.This PR adds a function that does precisely that, correctly get the bot's xp points.
That of course would make the
.points
property useless, so I would suggest you accept #3125 too if backwards compatibility is not an issue