Update Docker setup #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a standard Node.js Dockerfile template and removes the old, unused entrypoint script.
Closed
|
I wouldn't worry too much about the DataStore stuff. It's legacy and not used anymore iirc. It was implemented because we didn't have an S3 source that supported the TLS version we needed at the time. But we have MinIO now |
|
Should the datastore route and associated configuration be removed then? |
|
That's out of scope for this PR imo |
|
The Docker image is up! https://hub.docker.com/r/matthewl246/pretendo-account It works fine with pretendo-docker. |
mrjvs
suggested changes
Jun 26, 2024
mrjvs
suggested changes
Jun 27, 2024
binaryoverload
approved these changes
Jul 1, 2024
mrjvs
approved these changes
Jul 1, 2024
|
If jvs approve, Jon hits button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This updates the Dockerfile and related configuration. The DataStore upload method has been updated to use an environment variable for the secret key for consistency with the server's other configuration.
This also adds a GitHub Action for building and pushing the Docker image to Docker Hub. The image is currently available at https://hub.docker.com/r/matthewl246/pretendo-account and will be deleted when this PR is merged.
What I'm implementing was an approved issue.This issue was approved internally.I have tested all of the Docker changes. I have not tested DataStore HMAC secret key usage because I am not sure how to fully test that, but I believe it should work because the key is the same format that
generate-keys.jsused.