Dockerize #73
Closed
Dockerize #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbarrow
reviewed
Jul 14, 2023
|
Superseded by #97 (except for the |
|
Should this just be closed? @MatthewL246 @SuperMarioDaBom |
|
If it has been properly superceded, sure. As @MatthewL246 mentioned, the DOCKER.md file can be backed up if it proves useful for the new PR. |
|
I think this can be safely closed, as GitHub keeps commits available even after a branch is deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with making this server Docker compatible. Detailed setup instructions coming soon.
Minimal testing was performed, as I do not have the infrastructure to test certain aspects. The server did run, and server code is not touched by this PR.
Setting as a draft PR for now. Waiting on SMM datastore key dependency to be removed. Will mark as ready for review once that change has been pushed to the dev branch, and Docker instructions have been created.