Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass failed state to retry handlers and support async #14746

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jul 24, 2024

This PR:

  • ensures we always pass a Failed state with the corresponding raised exception to retry_condition_fn's, to preserve behavioral compatibility with 2.x
  • supports asynchronous retry_condition_fn

Closes #14745

@cicdw cicdw requested a review from desertaxle July 24, 2024 21:22
@github-actions github-actions bot added 3.x bug Something isn't working labels Jul 24, 2024
Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #14746 will not alter performance

Comparing retry-bug-fix (868a0ea) with main (e430486)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit 09b7a48 into main Jul 24, 2024
33 checks passed
@cicdw cicdw deleted the retry-bug-fix branch July 24, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@task(retry_condition_fn=...) unable to catch Exceptions (3.0rc11)
2 participants