Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an AsyncTaskRunEngine and wire it up to run async tasks #14743

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Create an AsyncTaskRunEngine and wire it up to run async tasks #14743

merged 3 commits into from
Jul 26, 2024

Conversation

bunchesofdonald
Copy link
Contributor

@bunchesofdonald bunchesofdonald commented Jul 24, 2024 •
edited
Loading

This creates an AsyncTaskRunEngine and wires it up to run async tasks.

To reduce the code duplication I created a BaseTaskRunEngine that has all of the shared sync code, and then a SyncTaskRunEngine for sync tasks, and the new AsyncTaskRunEngine for async tasks.

Closes #14113

@bunchesofdonald bunchesofdonald added the enhancement An improvement of an existing feature label Jul 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #14743 will not alter performance

Comparing issue-14113-final-final (e57689e) with main (530521d)

Summary

✅ 5 untouched benchmarks

@github-actions github-actions bot added 3.x bug Something isn't working labels Jul 24, 2024
@bunchesofdonald bunchesofdonald marked this pull request as ready for review July 24, 2024 19:02
@bunchesofdonald bunchesofdonald requested a review from cicdw as a code owner July 24, 2024 19:02
@cicdw cicdw requested a review from desertaxle July 25, 2024 19:58
cicdw
cicdw reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

src/prefect/task_engine.py Outdated Show resolved Hide resolved
src/prefect/task_engine.py Show resolved Hide resolved
desertaxle
desertaxle reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I left a couple of small comments.

src/prefect/task_engine.py Outdated Show resolved Hide resolved
src/prefect/task_engine.py Outdated Show resolved Hide resolved
@bunchesofdonald bunchesofdonald force-pushed the issue-14113-final-final branch from 232aaac to 1fbba5c Compare July 26, 2024 15:18
cicdw
cicdw approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bunchesofdonald bunchesofdonald force-pushed the issue-14113-final-final branch from 1fbba5c to 6d0b47e Compare July 26, 2024 18:31
@bunchesofdonald bunchesofdonald force-pushed the issue-14113-final-final branch from 6d0b47e to e57689e Compare July 26, 2024 18:33
@bunchesofdonald bunchesofdonald merged commit 0d23f58 into main Jul 26, 2024
30 checks passed
@bunchesofdonald bunchesofdonald deleted the issue-14113-final-final branch July 26, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees
No one assigned
Labels
3.x bug Something isn't working enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task run creation blocks the event loop
3 participants
@bunchesofdonald @desertaxle @cicdw