feat: add a posthog capture event when a proxy record is created #26585
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlwaterfield
reviewed
Dec 2, 2024
zlwaterfield
reviewed
Dec 2, 2024
posthog/api/proxy_record.py
Outdated
| request.user.distinct_id, | ||
| "proxy record created", | ||
| properties={ | ||
| "organization_id": record.organization_id, |
There was a problem hiding this comment.
Should need org id because that's included in the groups
surbhi-posthog
changed the title
|
I've added groups param to pass in the org data. I'm still a bit confused on how to test this event. I'm used to making sure events hit final table as expected, which I wasn't able to perform. @zlwaterfield i know you mentioned that as long as we know the function was called, we don't have to worry about things downstream. The way I did this was ensure that there were no errors related to the reverse proxy capture event, but please let me know if there are other better ways to verify this. |
surbhi-posthog
requested review from
raquelmsmith,
zlwaterfield and
patricio-posthog
zlwaterfield
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm adding
managed reverse proxy createdevent on the backend. I'm assuming we use this in analytics downstream.Changes
Verified that a proxy was created successfully
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Cloud: Yes
How did you test this code?
Tested locally on: http://localhost:8000/project/2/settings/organization-proxy
If there are other suggestions on how to verify if the logs are working correctly, please let me know. I might be missing stuff here.