feat: adding a posthog capture event when a billing proxy is created #26562
Conversation
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
surbhi-posthog
requested review from
zlwaterfield,
raquelmsmith and
patricio-posthog
| createRecordSuccess: () => actions.loadRecords(), | ||
| createRecordSuccess: () => { | ||
| actions.loadRecords() | ||
| posthog.capture('proxy_record_created') |
There was a problem hiding this comment.
Can you update the event name to follow the lowercase sentence case pattern we use? We should be more specific - maybe something like managed proxy record created.
I forgot to mention this but Raquel has been working on moving these events to the backend so ad blockers won't block them. Any crud operations where the events happen on the backup are good candidates for that. Do you want to take a stab at doing this on on the backend?
There was a problem hiding this comment.
yes for sure! I'm assuming that we can just abandon this frontend change and add the log solely in the backend. Let me know if I'm missing anything
There was a problem hiding this comment.
Yep, that's probably easiest. Apologies for missing that context.
|
Moved this logic to the backend here |
Problem
We want to add events when the features under the teams products are used. For example: managed_reverse_proxy, 2fa_enforcement etc.
in this PR, Im adding a capture event for only one feature
managed_reverse_proxy. I will follow up the PR with adding events for the remaining features that include but are not limited to:automatic_provisioning,
sso_enforcement,
2fa_enforcement,
priority_support etc.
Changes
Event is fired when a managed reverse proxy is created.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Cloud: Yes
self-hosted: TBD
How did you test this code?
Tested locally on: http://localhost:8000/project/2/settings/organization-proxy
Created a managed reverse proxy and verified that an event was fired in the console.