Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hide timezones behind FF #26478

Closed
wants to merge 2 commits into from
Closed

fix: Hide timezones behind FF #26478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d4ce20
Hide timezones behind FF
rafaeelaudibert Nov 27, 2024
a4c3956
Assert TabsTileTab up above to prevent tricky TS hack
rafaeelaudibert Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/lib/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ export const FEATURE_FLAGS = {
EXPERIMENTS_MIGRATION_DISABLE_UI: 'experiments-migration-disable-ui', // owner: @jurajmajerik #team-experiments
CUSTOM_CSS_THEMES: 'custom-css-themes', // owner: @daibhin
WEB_ANALYTICS_WARN_CUSTOM_EVENT_NO_SESSION: 'web-analytics-warn-custom-event-no-session', // owner: @robbie-c #team-web-analytics
WEB_ANALYTICS_TIMEZONE_TAB: 'web-analytics-timezone-tab', // owner: @rafaeelaudibert #team-web-analytics
} as const
export type FeatureFlagKey = (typeof FEATURE_FLAGS)[keyof typeof FEATURE_FLAGS]

Expand Down
22 changes: 13 additions & 9 deletions frontend/src/scenes/web-analytics/webAnalyticsLogic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
},
insightProps: createInsightProps(TileId.GEOGRAPHY, GeographyTab.MAP),
canOpenInsight: true,
},
} as TabsTileTab,
createTableTab(
TileId.GEOGRAPHY,
GeographyTab.COUNTRIES,
Expand All @@ -995,21 +995,25 @@ export const webAnalyticsLogic = kea<webAnalyticsLogicType>([
'Cities',
WebStatsBreakdown.City
),
createTableTab(
TileId.GEOGRAPHY,
GeographyTab.TIMEZONES,
'Timezones',
'Timezones',
WebStatsBreakdown.Timezone
),
createTableTab(
TileId.GEOGRAPHY,
GeographyTab.LANGUAGES,
'Languages',
'Languages',
WebStatsBreakdown.Language
),
],

// :BUG:, see #26475, hidden behind FF while we fix it
featureFlags[FEATURE_FLAGS.WEB_ANALYTICS_TIMEZONE_TAB]
? createTableTab(
TileId.GEOGRAPHY,
GeographyTab.TIMEZONES,
'Timezones',
'Timezones',
WebStatsBreakdown.Timezone
)
: null,
].filter(isNotNil),
}
: null,
{
Expand Down
Loading