fix: Hide timezones behind FF #26478
Open
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing incosistent values in production, let's hide it behind a FF for now
rafaeelaudibert
commented
Nov 27, 2024
| WebStatsBreakdown.Timezone | ||
| ) | ||
| : null, | ||
| ].filter((x) => x !== null), |
There was a problem hiding this comment.
Yes, it's complex, TS wouldn't let me otherwise
There was a problem hiding this comment.
It's temporary, so I'm fine with how bad this looks
There was a problem hiding this comment.
We have isNotNil as a type guard, which can work well for this kind of thing. You might be able to add .filter(isNotNil) to the outer array, and let this be null without needing to create an inner array
There was a problem hiding this comment.
That didn't work on its own, but I changed the code slightly, it looks nicer now
rafaeelaudibert
changed the title
This is simpler than what we had before
|
Size Change: +56 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing inconsistent values in production, let's hide it behind a FF for now
See #26475