Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more ad/campaign ids #20760

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: Add more ad/campaign ids #20760

merged 1 commit into from
Mar 7, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Mar 7, 2024

Problem

There are some major platforms where we don't capture the relevant ids. I've added support for Google Ads 360, Twitter, LinkedIn, Bing, Instagram, TikTok, and Mailchimp

Changes

Add

  • gclcsrc
  • dclid
  • twclid
  • li_fat_id
  • mc_cid
  • igshid
  • ttclid

See PostHog/posthog-js#1057 for where I've added this to posthog-js

How did you test this code?

n/a

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@robbie-c robbie-c marked this pull request as ready for review March 7, 2024 15:39
@robbie-c robbie-c merged commit 1a50c27 into master Mar 7, 2024
81 checks passed
@robbie-c robbie-c deleted the add-more-ad-ids branch March 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants