Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more ad/campaign ids #1057

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: Add more ad/campaign ids #1057

merged 1 commit into from
Mar 7, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Mar 7, 2024

Changes

Add more ad/campaign ids, see PostHog/posthog#20760 for where I've added this to the pipeline

Add

  • gclcsrc
  • dclid
  • twclid
  • li_fat_id
  • mc_cid
  • igshid
  • ttclid

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

github-actions bot commented Mar 7, 2024

Size Change: +260 B (0%)

Total Size: 859 kB

Filename Size Change
dist/array.full.js 185 kB +65 B (0%)
dist/array.js 126 kB +65 B (0%)
dist/es.js 126 kB +65 B (0%)
dist/module.js 126 kB +65 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 58.6 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@robbie-c robbie-c marked this pull request as ready for review March 7, 2024 15:22
@robbie-c robbie-c requested a review from pauldambra March 7, 2024 15:22
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the comments for the future traveller 🙌

@robbie-c robbie-c merged commit 083a453 into main Mar 7, 2024
17 checks passed
@robbie-c robbie-c deleted the add-more-ad-ids branch March 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants