Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor request to make sure we only use available transports #1166

Merged
merged 4 commits into from
May 8, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

Possibly fixes #1079

  • Generate the list of available request transports
  • Try to use the one requested, falling back to whatever is available

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview May 7, 2024 4:46pm

Copy link

github-actions bot commented May 7, 2024

Size Change: +1.4 kB (0%)

Total Size: 974 kB

Filename Size Change
dist/array.full.js 234 kB +348 B (0%)
dist/array.js 131 kB +349 B (0%)
dist/es.js 132 kB +349 B (0%)
dist/module.js 132 kB +349 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 57.2 kB
dist/surveys.js 58.8 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheekily included a fix to save myself another PR

tested this locally with api_transport explicitly set to each of the three options it takes and could capture events and see the transport flick between xhr and fetch so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"TypeError: D is not a constructor" in version >=1.112.0
2 participants