Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove transport method that doesn't work #1167

Merged
merged 7 commits into from
May 8, 2024

Conversation

pauldambra
Copy link
Member

reviewing #1166 made me wonder about the scriptRequest transport

I tried it locally and you simply get a 400 back from PostHog so it doesn't work

plus you'd need to be in a browser that doesn't support xhr or fetch... even IE11 doesn't meet those criteria

stacked on top of #1166 to (hopefully) avoid merge conflict faff

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview May 8, 2024 7:19am

@pauldambra pauldambra requested a review from benjackwhite May 7, 2024 17:26
Copy link

github-actions bot commented May 7, 2024

Size Change: -1.01 kB (0%)

Total Size: 973 kB

Filename Size Change
dist/array.full.js 234 kB -254 B (0%)
dist/array.js 131 kB -251 B (0%)
dist/es.js 131 kB -251 B (0%)
dist/module.js 132 kB -251 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 57.2 kB
dist/surveys.js 58.8 kB

compressed-size-action

Base automatically changed from fix/fetch-if-not-xml to main May 8, 2024 07:02
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about exactly this. Thanks for following through on that private thought 😅

@davidbarratt
Copy link

Just a slight comment here for historical purposes... the purpose of the script transport wouldn't be for browsers that do not support XHR, it would be for browsers that do not support CORS which is none of them at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants