Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: measure identified events #1114

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Apr 3, 2024

Changes

Send $is_identified property as a boolean, based on whether identify has been called

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@posthog-bot
Copy link
Collaborator

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@robbie-c robbie-c added the bump patch Bump patch version when this PR gets merged label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Size Change: +216 B (0%)

Total Size: 944 kB

Filename Size Change
dist/array.full.js 225 kB +54 B (0%)
dist/array.js 124 kB +54 B (0%)
dist/es.js 124 kB +54 B (0%)
dist/module.js 125 kB +54 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@robbie-c robbie-c requested a review from pauldambra April 3, 2024 17:24
@robbie-c robbie-c marked this pull request as ready for review April 3, 2024 17:24
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbie-c robbie-c merged commit 4e7c87d into main Apr 3, 2024
20 checks passed
@robbie-c robbie-c deleted the feat/measure-identified-events branch April 3, 2024 18:06
@robbie-c robbie-c mentioned this pull request Apr 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants