Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix $is_identified #1116

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: Fix $is_identified #1116

merged 1 commit into from
Apr 5, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Apr 5, 2024

Changes

Fix a big that was introduced in #1114 where $is_identified can be false even when the user is identified.

Instead of letting the session_persistance take priority over the regular persistance, return true if either persistance know the user is identified.

Also added a test to cover this case, and some scripts + docs to make it simpler to use the nextjs playground as a place to test posthog-js changes.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@robbie-c robbie-c marked this pull request as ready for review April 5, 2024 11:00
Copy link

github-actions bot commented Apr 5, 2024

Size Change: +276 B (0%)

Total Size: 944 kB

Filename Size Change
dist/array.full.js 225 kB +69 B (0%)
dist/array.js 124 kB +69 B (0%)
dist/es.js 125 kB +69 B (0%)
dist/module.js 125 kB +69 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.1 kB
dist/recorder-v2.js 106 kB
dist/recorder.js 106 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@robbie-c robbie-c force-pushed the fix/is_identified branch from 86e8ae8 to 5fc2f20 Compare April 5, 2024 11:07
@robbie-c robbie-c merged commit a09f28c into main Apr 5, 2024
11 checks passed
@robbie-c robbie-c deleted the fix/is_identified branch April 5, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant