Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return typing of global functions #1081

Merged
merged 1 commit into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/replay/sessionrecording.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class SessionRecording {
private _sampleRate: number | null = null
private _minimumDuration: number | null = null

private _fullSnapshotTimer?: number
private _fullSnapshotTimer?: ReturnType<typeof setInterval>

// Util to help developers working on this feature manually override
_forceAllowLocalhostNetworkCapture = false
Expand Down
2 changes: 1 addition & 1 deletion src/request-queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export class RequestQueue {
// We start in a paused state and only start flushing when enabled by the parent
private isPaused: boolean = true
private queue: QueuedRequestOptions[] = []
private flushTimeout?: number // to become interval for reference to clear later
private flushTimeout?: ReturnType<typeof setTimeout>
private flushTimeoutMs = 3000
private sendRequest: (req: QueuedRequestOptions) => void

Expand Down
2 changes: 1 addition & 1 deletion src/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const _fetch = (options: RequestOptions) => {
}

const url = options.url
let aborter: { signal: any; timeout: number } | null = null
let aborter: { signal: any; timeout: ReturnType<typeof setTimeout> } | null = null

if (AbortController) {
const controller = new AbortController()
Expand Down
Loading