fix: return typing of global functions #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Seeing these errors locally
Don't know why this only happens in my environment but TS suggests the return type should be
NodeJS.Timeout
. Depending on the environment posthog-js is running in we can support the global functions return type.More context: https://stackoverflow.com/questions/45802988/typescript-use-correct-version-of-settimeout-node-vs-window
Checklist