chore: deprecate property_blacklist in favor of property_denylist #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @marandaneto! 👋 |
|
Size Change: +869 B (0%) Total Size: 860 kB
ℹ️ View Unchanged
|
marandaneto
commented
Feb 27, 2024
pauldambra
approved these changes
Feb 27, 2024
src/posthog-core.ts
Outdated
| _each(property_blacklist, function (blacklisted_prop) { | ||
| delete properties[blacklisted_prop] | ||
| // since property_blacklist is deprecated in favor of property_denylist, we merge both of them here | ||
| const property_denylist = [...this.config.property_blacklist, ...this.config.property_denylist] |
There was a problem hiding this comment.
also feels like we should merge this once, i think maybe we have to do it in init and in set_config
that way internally the SDK only has a denylist, and existing config gets copied into it whenever we evaluate the config
There was a problem hiding this comment.
discussed offline, and added a TODO for now, it requires a bit of test refactoring to make it work since the override option always replaces the set_config call.
benjackwhite
approved these changes
Feb 27, 2024
This reverts commit 70ecf32.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let's make our config more inclusive.
Checklist