Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename blacklist to denylist #7924

Merged
merged 1 commit into from
Mar 9, 2024
Merged

chore: rename blacklist to denylist #7924

merged 1 commit into from
Mar 9, 2024

Conversation

marandaneto
Copy link
Member

Changes

Relates to PostHog/posthog-js#1044

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

Article checklist

  • I've added (at least) 3-5 internal links to this new article
  • I've added keywords for this page to the rank tracker in Ahrefs
  • I've checked the preview build of the article
  • The date on the article is today's date
  • I've added this to the relevant "Tutorials and guides" docs page (if applicable)

Useful resources

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Feb 27, 2024 2:03pm

@marandaneto marandaneto marked this pull request as draft February 27, 2024 13:44
@marandaneto marandaneto requested a review from a team February 27, 2024 13:44
@marandaneto
Copy link
Member Author

will keep it a draft until the PR is released

pauldambra
pauldambra approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i missed this, sorry

@marandaneto marandaneto marked this pull request as ready for review March 9, 2024 09:01
@marandaneto marandaneto merged commit 98c2511 into master Mar 9, 2024
2 checks passed
@marandaneto marandaneto deleted the chore/denylist branch March 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra