Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio/quodlibet: Patch for Python 3.12 compatibility. #258

Closed
wants to merge 2 commits into from

Conversation

nick8325
Copy link
Contributor

No description provided.

Copy link

reverse dependencies - audio/quodlibet

None

Copy link

✅ sbolint - audio/quodlibet ✅

sbolint: quodlibet checks out OK

@nick8325
Copy link
Contributor Author

nick8325 commented Dec 3, 2024

Oh, it looks like the pull request has gone weird since it includes the "20241124.1 global branch merge" commit, want me to rebase on 20241130.1?

@Ponce
Copy link
Owner

Ponce commented Dec 4, 2024

Oh, it looks like the pull request has gone weird since it includes the "20241124.1 global branch merge" commit, want me to rebase on 20241130.1?

there's no problem, I'll just take the commit.

what puzzles me is that on my installation quodlibet builds fine against python-3.12.x with no need of any patches: do you still want me to push this?

@nick8325
Copy link
Contributor Author

nick8325 commented Dec 4, 2024

Without the patch it builds but fails at runtime with some kind of module import error - at least on my machine. Are you also able to run it without the patch?

@Ponce
Copy link
Owner

Ponce commented Dec 4, 2024

Without the patch it builds but fails at runtime with some kind of module import error - at least on my machine. Are you also able to run it without the patch?

actually no: sorry I didn't try it before...
thanks for the patch: I pushed it in a dedicated branch!

@Ponce Ponce closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants