Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl node type filter for nodes, pathfromgraph and pathfromnode #1606

Merged
merged 33 commits into from
May 29, 2024

Conversation

shivam-880
Copy link
Collaborator

What changes were proposed in this pull request?

Fixes #1599

Why are the changes needed?

Missing apis

Does this PR introduce any user-facing change? If yes is this documented?

Yes

How was this patch tested?

Unit tested

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

@shivam-880 shivam-880 marked this pull request as ready for review May 22, 2024 16:44
@shivam-880 shivam-880 requested review from miratepuffin and ljeub-pometry and removed request for miratepuffin May 22, 2024 16:55
@shivam-880 shivam-880 requested a review from miratepuffin May 22, 2024 16:56
Copy link
Collaborator

@ljeub-pometry ljeub-pometry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some warnings to fix

raphtory/src/db/api/view/node.rs Outdated Show resolved Hide resolved
raphtory/src/db/graph/mod.rs Outdated Show resolved Hide resolved
miratepuffin and others added 8 commits May 28, 2024 12:21
# Conflicts:
#	raphtory/src/db/api/view/internal/core_ops.rs
#	raphtory/src/db/api/view/mod.rs
#	raphtory/src/db/api/view/node.rs
#	raphtory/src/db/graph/graph.rs
#	raphtory/src/db/graph/nodes.rs
#	raphtory/src/db/internal/core_ops.rs
#	raphtory/src/lib.rs
@miratepuffin miratepuffin merged commit c3289dc into master May 29, 2024
13 checks passed
@miratepuffin miratepuffin deleted the fix/node_type2 branch May 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue with nodes type filter
4 participants