fix node type filter #1600
Closed
fix node type filter #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
requested changes
May 14, 2024
There was a problem hiding this comment.
This needs to be exposed in python - we also need to just swap the semantics for the node_filter function on nodes instead of adding a new name.
Can you also add some tests to make sure this works with layered graphs, windowed graphs, subgraphs etc as you are utilising the base graph.
What happens when you call the function twice?
i.e. g.nodes().node_filter(["a","b"]).neighbours.node_filter(["b","c"]).collect()
|
Now covered by a better implementation in #1606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes #1599
Why are the changes needed?
Same as above
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
Unit test
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
#1599
Are there any further changes required?
No