-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option for "data deletion" rubric entry #97
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request. @milesmcc has been assigned to review these changes, provide feedback, and determine next steps. If you haven't already, please ensure your changes pass all the automated tests. Look in the "Checks" box below and "Files changed" tab to see test results. To learn about the PrivacySpy contribution process, check out the contribution guide.
|
(forgot to pull before branching off and so there are a few unnecessary commits) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the documentation should update itself, this looks solid. Time to find out what policies need to be altered :\
I wonder if |
So for instance, everything but legally required (for tax audits/complaince, for instance)? I could see that being a better fit in that scenario, but you could also argue that there should be a |
Adding |
Since it's been a hot minute since we've had this discussion, I figured I'd add my 2¢ of how options might be:
I'm not sure how I would score it personally, but I think it would cover the basis for most any product. But I do feel like this is something we should integrate, even though we will have to revisit several policies to ensure they have the proper score afterwords. |
Figured I'd bump this PR to make sure that we give it the attention needed to make this important shift for this improvement to scoring. |
@doamatto is this ready to be merged or would you like to discuss alternative rubric options? |
I think as Igor mentioned, a |
Type of pull request: rubric revision
Related issues: list the related issues here (if applicable): Closes #54
The linked issue raised an important concern that our rubric doesn't exhaustively cover how data could be deleted. Currently, we only have "automated" and "by contacting someone," but it could be the case (as in the case of Discord) that automated mechanisms delete only some data. I think it makes sense to include an option to specify that only some data will be removed automatically. I do realize that my proposed edit might still not cover all cases, so this PR is open to suggestions.