Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product addition: Blizzard Entertainment #84

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Product addition: Blizzard Entertainment #84

merged 6 commits into from
Jun 18, 2021

Conversation

Deivedux
Copy link
Contributor

@Deivedux Deivedux commented Jun 1, 2021

Type of pull request: product addition

Related issues: no issues


A few things worth mentioning.

  • The list of hostnames may not be complete, since there are so many owned by Blizzard.
  • There are 2 different policies, called Privacy Policy and Online Privacy Policy. I chose the latter one because that's the first result that appeared in search engines, and it's the one that Blizzard themselves makes the most accessible from their websites' footer.

@privacyspy-bot
Copy link

privacyspy-bot bot commented Jun 1, 2021

Thanks for submitting this pull request. @milesmcc has been assigned to review these changes, provide feedback, and determine next steps.

If you haven't already, please ensure your changes pass all the automated tests. Look in the "Checks" box below and "Files changed" tab to see test results.

To learn about the PrivacySpy contribution process, check out the contribution guide.

Note to maintainers: if this pull request passes all tests and code reviews, it should be squashed and merged.

@privacyspy-bot privacyspy-bot bot added size/M icon How products look on PrivacySpy product Related to a product on PrivacySpy labels Jun 1, 2021
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it more once I'm back at my flat or have a chance while on campus.

products/blizzard-entertainment.toml Show resolved Hide resolved
Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more sites that would go under this product

"heroesofthestorm.com"
"heroesofthestorm.com",
"overwatchleague.com",
"overwatchcontenders.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:

- communitytournaments.blizzardesports.com
- blizzard.gamespress.com
- blizzcon.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine if subdomains are included as well?

Copy link
Contributor Author

@Deivedux Deivedux Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to add the second one, as gamespress.com is its own domain that may conflict with their policy in the future.

Copy link
Collaborator

@doamatto doamatto Jun 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine if subdomains are included as well?

That would be best asked to @milesmcc or @ibarakaiev, but my assumption is that it's whatever the hostname is + a wildcard (*.google.com would be under Google, but news.google.com could have a seperate entry, for instance)

Copy link
Collaborator

@doamatto doamatto Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the extension source and saw that (in theory) the subdomain will be fine. If you want to be certain, I can load up a custom version of the extension and this PR locally and double-check that it doesn't have any issues (you can if you want as well)

Copy link
Collaborator

@doamatto doamatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait for a proper review. Here's my thoughts.

@@ -0,0 +1,80 @@
name = "Blizzard Entertainment"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blizzard Entertainment (US) would be more accurate, as the policies vary between regions.

[rubric.data-deletion]
value = "no"
citations = [
"You may also submit a verifiable request for us to delete either: (1) your marketing information; or (2) your Battle.net account and your marketing information.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be automated: The deletion of a Battle.net account is permanent and cannot be reversed; also, all games, assets and history will also be permanently deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the account deletion is permanent, but they do mention that they may retain some information for reasons like (d) comply with law enforcement requests pursuant to lawful process, (e) for scientific or historical research, no? This to me suggests that they will still have enough personal information to give away to law enforcement even after the account is deleted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first bit is technically unavoidable and something I think many ignore because some information does have to be. Prime example is an order history for tax audits. May be a good idea to get a second opinion from @milesmcc or @ibarakaiev though.


[rubric.history]
value = "no"
notes = ["The policy's history is not made available."]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be last modified. Date at bottom of policy: This Privacy Policy was last updated on October 22, 2020


[rubric.revision-notify]
value = "no"
citations = ["This Privacy Policy may change from time to time, so please check back periodically to ensure that you are aware of any changes. If we make a material change to this Privacy Policy, we will notify you by posting the change on our websites or in this Privacy Policy and, if necessary, give you additional choices regarding such change before the change becoming effective."]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material changes would qualify as revision notifications, and should bring this score up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly do not know why I put no here...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha all good bruv

@milesmcc
Copy link
Collaborator

@doamatto is right! Incorporate those suggestions and we should be good to go.

Copy link
Contributor Author

@Deivedux Deivedux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to look into these before merging.

products/blizzard-entertainment.toml Show resolved Hide resolved
products/blizzard-entertainment.toml Show resolved Hide resolved
@doamatto
Copy link
Collaborator

Looks pretty solid to me; some things can be changed after #97 is finished, but apart from that it looks basically bang-on to me

@milesmcc milesmcc merged commit c3e0d76 into Politiwatch:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon How products look on PrivacySpy product Related to a product on PrivacySpy size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants