Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product addition: Blizzard Entertainment #84

Merged
merged 6 commits into from
Jun 18, 2021
+80 −0
Merged

Product addition: Blizzard Entertainment #84

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d204385
Added Blizzard
Deivedux Jun 1, 2021
39ace96
Update blizzard-entertainment.toml
Deivedux Jun 1, 2021
9e2b9e6
Update blizzard-entertainment.toml
Deivedux Jun 1, 2021
6a94ea4
Update blizzard-entertainment.toml
Deivedux Jun 2, 2021
0ad0e31
Update blizzard-entertainment.toml
Deivedux Jun 2, 2021
a62bc0d
Update blizzard-entertainment.toml
Deivedux Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion products/blizzard-entertainment.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ hostnames = [
"playwarcraft3.com",
"playoverwatch.com",
"diabloimmortal.com",
"heroesofthestorm.com"
"heroesofthestorm.com",
"overwatchleague.com",
"overwatchcontenders.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add:

- communitytournaments.blizzardesports.com
- blizzard.gamespress.com
- blizzcon.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine if subdomains are included as well?

Copy link
Contributor Author

@Deivedux Deivedux Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to add the second one, as gamespress.com is its own domain that may conflict with their policy in the future.

Copy link
Collaborator

@doamatto doamatto Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine if subdomains are included as well?

That would be best asked to @milesmcc or @ibarakaiev, but my assumption is that it's whatever the hostname is + a wildcard (*.google.com would be under Google, but news.google.com could have a seperate entry, for instance)

Copy link
Collaborator

@doamatto doamatto Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the extension source and saw that (in theory) the subdomain will be fine. If you want to be certain, I can load up a custom version of the extension and this PR locally and double-check that it doesn't have any issues (you can if you want as well)

]
sources = ["https://www.blizzard.com/en-us/legal/a4380ee5-5c8d-4e3b-83b7-ea26d01a9918/blizzard-entertainment-online-privacy-policy"]
contributors = ["Deivedux"]
Expand Down