Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModeSense page 0x25 (DEC special function control page) #1412

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Jan 14, 2024

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6) page 0x25
when probing for disks. A disk won't be recognized if this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes #1410

@kkaempf kkaempf requested review from akuker and rdmark as code owners January 14, 2024 13:40
cpp/devices/scsihd.cpp Outdated Show resolved Hide resolved
@kkaempf kkaempf changed the title Add ModeSense page 0x25 (DEC unique page) Add ModeSense page 0x25 (DEC special function control page) Jan 15, 2024
@kkaempf kkaempf requested a review from rdmark January 15, 2024 17:58
cpp/test/scsihd_test.cpp Outdated Show resolved Hide resolved
@rdmark
Copy link
Member

rdmark commented Jan 18, 2024

@kkaempf Please rebase your branch with develop now so that we can confirm that this code passes in the updated CI pipeline. :)

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6)
page 0x25 when probing for disks. A disk won't be recognized if
this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes PiSCSI#1410

Signed-off-by: Klaus Kämpf <[email protected]>
@kkaempf
Copy link
Contributor Author

kkaempf commented Jan 18, 2024

@kkaempf Please rebase your branch with develop now so that we can confirm that this code passes in the updated CI pipeline. :)

Done.
Tests still pass for me 🤞🏻

Copy link

sonarcloud bot commented Jan 18, 2024

@rdmark
Copy link
Member

rdmark commented Jan 18, 2024

@kkaempf Yay! Thanks for working through that issue.

May I ask you to respond to my earlier code review question? It might be my misunderstanding the code, but I would like to get clarity before merging.

@kkaempf
Copy link
Contributor Author

kkaempf commented Jan 18, 2024

Sorry, hadn't realize that there was an outstanding question. Answered now.

Copy link
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@rdmark rdmark merged commit 1121b8d into PiSCSI:develop Jan 19, 2024
8 checks passed
kkaempf added a commit to kkaempf/piscsi that referenced this pull request Apr 2, 2024
)

* Add ModeSense page 0x25 (DECSpecialFunctionControlPage)

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6)
page 0x25 when probing for disks. A disk won't be recognized if
this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes PiSCSI#1410

Signed-off-by: Klaus Kämpf <[email protected]>
rdmark added a commit that referenced this pull request Apr 9, 2024
rdmark added a commit that referenced this pull request Apr 13, 2024
…ging (#1451)

* Revert "Don't ResizeCache on sector change if no filename is defined (#1438)"

This reverts commit dd9a329.

* Revert "Add ModeSense page 0x25 (DEC special function control page) (#1412)"

This reverts commit 1121b8d.

* Revert "DiskCache needs a size"

This reverts commit 7cc8df2.

* Revert "Honor sector size change via ModeSelect6 in scsicd (#1406)"

This reverts commit b7f65d3.

* Revert "Multiple fixes for ModeSelect (#1405)"

This reverts commit ad5eae9.
rdmark pushed a commit that referenced this pull request May 1, 2024
* Add ModeSense page 0x25 (DECSpecialFunctionControlPage)

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6)
page 0x25 when probing for disks. A disk won't be recognized if
this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes #1410

Signed-off-by: Klaus Kämpf <[email protected]>
rdmark added a commit that referenced this pull request May 1, 2024
…ging (#1451)

* Revert "Don't ResizeCache on sector change if no filename is defined (#1438)"

This reverts commit dd9a329.

* Revert "Add ModeSense page 0x25 (DEC special function control page) (#1412)"

This reverts commit 1121b8d.

* Revert "DiskCache needs a size"

This reverts commit 7cc8df2.

* Revert "Honor sector size change via ModeSelect6 in scsicd (#1406)"

This reverts commit b7f65d3.

* Revert "Multiple fixes for ModeSelect (#1405)"

This reverts commit ad5eae9.
kkaempf added a commit to kkaempf/piscsi that referenced this pull request Aug 9, 2024
)

* Add ModeSense page 0x25 (DECSpecialFunctionControlPage)

VAXServer 3100 (CPU KA41-E) console firmware issues ModeSense(6)
page 0x25 when probing for disks. A disk won't be recognized if
this returns an error.

The DEC SCSI specification[1], section 8.5 documents this page.

[1] https://manx-docs.org/collections/antonio/dec/dec-scsi.pdf

Fixes PiSCSI#1410

Signed-off-by: Klaus Kämpf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VAXServer 3100 firmware requests unsupported ModeSense page 37 (0x25)
2 participants