Rename DECUniquePage to DECSpecialFunctionControlPage

Signed-off-by: Klaus Kämpf <[email protected]>
PiSCSI · Jan 18, 2024 · 753a614 · 753a614
1 parent e5b0032
commit 753a614
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/cpp/devices/scsihd.cpp b/cpp/devices/scsihd.cpp
@@ -97,9 +97,9 @@ void SCSIHD::AddFormatPage(map<int, vector<byte>>& pages, bool changeable) const
 	EnrichFormatPage(pages, changeable, 1 << GetSectorSizeShiftCount());
 }
 
-// Page code 37 (25h) - DEC Unique Page
+// Page code 37 (25h) - DEC Special Function Control page
 
-void SCSIHD::AddDECUniquePage(map<int, vector<byte>>& pages, bool changeable) const
+void SCSIHD::AddDECSpecialFunctionControlPage(map<int, vector<byte>>& pages, bool changeable) const
 {
 	vector<byte> buf(25);
 
@@ -119,9 +119,9 @@ void SCSIHD::AddDECUniquePage(map<int, vector<byte>>& pages, bool changeable) co
 
 void SCSIHD::AddVendorPage(map<int, vector<byte>>& pages, int page, bool changeable) const
 {
-	// Page code 0x25: DEC unique
+	// Page code 0x25: DEC Special Function Control page
 	if (page == 0x25 || page == 0x3f) {
-		AddDECUniquePage(pages, changeable);
+		AddDECSpecialFunctionControlPage(pages, changeable);
 	}
 	// Page code 48
 	if (page == 0x30 || page == 0x3f) {

diff --git a/cpp/devices/scsihd.h b/cpp/devices/scsihd.h
@@ -40,7 +40,7 @@ class SCSIHD : public Disk
 	void ModeSelect(scsi_defs::scsi_command, cdb_t, span<const uint8_t>, int) override;
 
 	void AddFormatPage(map<int, vector<byte>>&, bool) const override;
-	void AddDECUniquePage(map<int, vector<byte>>&, bool) const;
+	void AddDECSpecialFunctionControlPage(map<int, vector<byte>>&, bool) const;
 	void AddVendorPage(map<int, vector<byte>>&, int, bool) const override;
 
 private:

diff --git a/cpp/test/mocks.h b/cpp/test/mocks.h
@@ -360,7 +360,7 @@ class MockSCSIHD : public SCSIHD //NOSONAR Ignore inheritance hierarchy depth in
 	FRIEND_TEST(ScsiHdTest, FinalizeSetup);
 	FRIEND_TEST(ScsiHdTest, GetProductData);
 	FRIEND_TEST(ScsiHdTest, SetUpModePages);
-	FRIEND_TEST(ScsiHdTest, DECUniquePage);
+	FRIEND_TEST(ScsiHdTest, DECSpecialFunctionControlPage);
 	FRIEND_TEST(ScsiHdTest, GetSectorSizes);
 	FRIEND_TEST(ScsiHdTest, ModeSelect);
 	FRIEND_TEST(PiscsiExecutorTest, SetSectorSize);

diff --git a/cpp/test/scsihd_test.cpp b/cpp/test/scsihd_test.cpp
@@ -102,7 +102,7 @@ TEST(ScsiHdTest, SetUpModePages)
 	ScsiHdTest_SetUpModePages(pages);
 }
 
-TEST(ScsiHdTest, DECUniquePage)
+TEST(ScsiHdTest, DECSpecialFunctionControlPage)
 {
 	map<int, vector<byte>> pages;
 	vector<byte> buf;