Normalize <said><label/>...</said> interaction
#1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents in this repository tend to follow a format that looks like this: ``` <said who="#NAME"> <label>NAME_OR_ABBR.</label> ... </said> ``` 1. The `who` attribute starts with `#` and contains the full name. 2. The `label` element contains the name or an abbr., followed by a period. This commit fixes the handful of instances that deviate from this pattern.
lcerrato
reviewed
Nov 24, 2023
| @@ -96,7 +96,7 @@ schematypens="http://relaxng.org/ns/structure/1.0"?> | |||
| <div type="textpart" subtype="section" n="intro"> <head>INTRODUCTION</head> | |||
| <p rend="indent">Plutarch’s essay on the changed custom at Delphi is quite as interesting for its digressions as for its treatment of the main topic. Portents, coincidences, history, a little philosophy, stories of persons like Croesus, Battus, Lysander, Rhodope, finally lead up to the statement that many oracles used to be delivered in prose, although still more in early times were delivered in verse; but the present age calls for simplicity and directness instead of the ancient obscurity and grandiloquence. </p> <p rend="indent"> We possess a considerable body of Delphic oracles preserved in Greek literature, as, for example, the famous oracle of the <q>wooden wall</q> (Herodotus, vii. 141). Practically all of these are in hexameter verse. Many more records of oracles merely state that someone consulted the oracle and was told to perform a certain deed, or was told that something would or might happen, often with certain limitations. We have, therefore, no means of determining the truth of Plutarch’s statement, but there is little doubt that he is right. If we possessed his lost work, <foreign xml:lang="grc">Χρησμῶν συναγωγή</foreign> (no. 171 in Lamprias’s list), we should have more abundant data on which to base our decision. </p> <p rend="indent"> The essay often exhibits Plutarch at his best. Hartman thinks that Plutarch hoped that the.work <pb xml:id="v.5.p.257"/> would be read at Rome, and therefore inserted the encomium of Roman rule near the end. </p> <p rend="indent"> The essay stands as no. 116 in Lamprias’s catalogue. It is found in only two mss. and in a few places the tradition leaves us in doubt, but, for the most part, the text is fairly clear. </p> <p rend="indent"> The references to the topography and monuments of Delphi have become more intelligible since the site was excavated by the French. Pomtow, in the <title xml:lang="deu" rend="italic">Berliner Pkilologische Wochenschrift</title>, 1912, p. 1170, gives an account of the monuments visited by the company in this essay. </p> </div> <pb xml:id="v.5.p.259"/> | |||
| <div type="textpart" subtype="section" n="1"><p rend="center"><label>(The persons who take part in the dialogue are Basilocles and Philinus, who serve to introduce the later speakers; Diogenianus, Theon, Sarapion, Boethus, as well as Philinus himself and some professional guides.)</label></p> | |||
| <p rend="indent"><said who="#Basilocles"><label>BASILOCLES.</label> You people have kept it up till well into the evening, Philinus, escorting the foreign visitor around among the statues and votive offerings. For my part, I had almost given up waiting for you.</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> The fact is, Basilocles, that wre went slowly, sowing words, and reaping them straightway with strife, like the men sprung from the Dragon’s teeth, words with meanings behind them of the contentious sort, which sprang up and flourished along our way.</said> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES.</label> Will it be necessary to call in someone else of those who were with you; or are you willing, as a favour, to relate in full what your conversation was and who took part in it?</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> It looks, Basilocles, as if I shall have that to do. In fact, it would not be easy for you to find anyone of the others in the town, for I saw most of them once more on their way up to the Cory ei an cave and Lycoreia<note resp="editor" place="unspecified" anchored="true">Pausanias, x. 6. 2-3.</note> with the foreign visitor.</said> <pb xml:id="v.5.p.261"/> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES</label>. Our visitor is certainly eager to see the sights, and an unusually eager listener.</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> But even more is he a scholar and a student. However, it is not this that most deserves our admiration, but a winning gentleness, and his willingness to argue and to raise questions, which comes from his intelligence, and shows no dissatisfaction nor contrariety with the answers. So, after being with him but a short time, one would say, <q>O child of a goodly father!</q> <note resp="editor" place="unspecified" anchored="true"> <foreign xml:lang="lat">Cf.</foreign> Plato, <title rend="italic">Republic</title>, 368 a.</note> You surely know Diogenianus, one of the best of men.</said> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES.</label> I never saw him myself, Philinus, but I have met many persons who expressed a strong approval of the man’s words and character, and who had other compliments of the same nature to say of the young man. But, my friend, what was the beginning and occasion of your conversation?</said> </p> </div> | |||
| <p rend="indent"><said who="#Basilocles"><label>BASILOCLES.</label> You people have kept it up till well into the evening, Philinus, escorting the foreign visitor around among the statues and votive offerings. For my part, I had almost given up waiting for you.</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> The fact is, Basilocles, that wre went slowly, sowing words, and reaping them straightway with strife, like the men sprung from the Dragon’s teeth, words with meanings behind them of the contentious sort, which sprang up and flourished along our way.</said> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES.</label> Will it be necessary to call in someone else of those who were with you; or are you willing, as a favour, to relate in full what your conversation was and who took part in it?</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> It looks, Basilocles, as if I shall have that to do. In fact, it would not be easy for you to find anyone of the others in the town, for I saw most of them once more on their way up to the Cory ei an cave and Lycoreia<note resp="editor" place="unspecified" anchored="true">Pausanias, x. 6. 2-3.</note> with the foreign visitor.</said> <pb xml:id="v.5.p.261"/> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES.</label> Our visitor is certainly eager to see the sights, and an unusually eager listener.</said> </p> <p rend="indent"> <said who="#Philinus"><label>PHILINUS.</label> But even more is he a scholar and a student. However, it is not this that most deserves our admiration, but a winning gentleness, and his willingness to argue and to raise questions, which comes from his intelligence, and shows no dissatisfaction nor contrariety with the answers. So, after being with him but a short time, one would say, <q>O child of a goodly father!</q> <note resp="editor" place="unspecified" anchored="true"> <foreign xml:lang="lat">Cf.</foreign> Plato, <title rend="italic">Republic</title>, 368 a.</note> You surely know Diogenianus, one of the best of men.</said> </p> <p rend="indent"> <said who="#Basilocles"><label>BASILOCLES.</label> I never saw him myself, Philinus, but I have met many persons who expressed a strong approval of the man’s words and character, and who had other compliments of the same nature to say of the young man. But, my friend, what was the beginning and occasion of your conversation?</said> </p> </div> | |||
There was a problem hiding this comment.
I am having trouble finding any difference here?
There was a problem hiding this comment.
Friendly tip: using git diff --word-diff-regex=. makes these kind of changes much easier to see. However, the change in the above line is this:
- <label>BASILOCLES</label>.
+ <label>BASILOCLES.</label>
|
@npmccallum |
This is a pre-existing stylistic choice inconsistency which I am not attempting to address in this PR. This PR attempts only to address syntactical inconsistencies. |
|
@npmccallum |
Yes, the existing files are inconsistent. I'm not attempting to address this particular inconsistency in this PR. I could file an issue for this.
This appears to be a bug with GitHub's HTML diff rendering. I see the changes easily using
- <label>BASILOCLES</label>.
+ <label>BASILOCLES.</label>
- <label>ΦΙΛΙΝΟΣ</label>
+ <label>ΦΙΛΙΝΟΣ.</label>
- <label>LAMPRIAS.</label> .
+ <label>LAMPRIAS.</label>
- <label></label> .
+ <label>LAMPRIAS.</label>
- <said who="Socrates"
+ <said who="#Socrates"
- <label>Socrates</label>
+ <label>Socrates.</label>
- <label>Soc</label>
+ <label>Soc.</label>
- <label>Crit..</label>
+ <label>Crit.</label> |
|
@lcerrato Any progress on this? |
|
@npmccallum (Also am on a limited schedule + holidays + other projects/deadlines). |
lcerrato
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents in this repository tend to follow a format that looks like this:
whoattribute starts with#and contains the full name.labelelement contains the name or an abbr., followed by a period.This commit fixes the handful of instances that deviate from this pattern.