Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlg0003_all_files #1500

Merged
merged 1 commit into from
Sep 14, 2023
Merged

tlg0003_all_files #1500

merged 1 commit into from
Sep 14, 2023

Conversation

AlisonBabeu
Copy link
Collaborator

Updated a number of URNs from deu to ger for consistency. Changed OPP URNs to 1st1K.
Other minor edit.s

Updated a number of URNs from deu to ger for consistency.
Changed OPP URNs to 1st1K.
Other minor edit.s
@lcerrato
Copy link
Collaborator

@AlisonBabeu
I have a silly question. It looks like there is mostly "deu" for German throughout this collection versus "ger" appearing only once. So in the body of most works, the default is the former. In development, there are over >1400 instances of deu versus 191 of ger.

@AlisonBabeu
Copy link
Collaborator Author

hey @lcerrato, do you mean deu to in language tagging? The only "ger" I changed here was to the URNs and the XML:BASE to be consistent across the collection,not language tagging itself. I've stuck with "deu" for the Unicode language tag.

@lcerrato
Copy link
Collaborator

@AlisonBabeu Yes, I was wondering why the URNs use ger when deu is the default elsewhere. Seems like we should choose one.

@AlisonBabeu
Copy link
Collaborator Author

I changed these from "deu" to ger because we had used "ger" in other 1st1K translations.

@lcerrato
Copy link
Collaborator

@AlisonBabeu
Do you think the file tags should read "ger" as well?

@lcerrato
Copy link
Collaborator

This needs to be fixed so that I can resolve #1474 which was closed (and subsequently closed the issue it was supposed to fix). So we have a "fixed" issue that is not actually fixed.
I have to manually add changed because of the subsequent conflicts I think.
Not sure what happened.

@lcerrato lcerrato merged commit 3ea9fa6 into master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants